Skip to content

fix(feature-ideation): discussion→dispatch redispatch bridge in the template - #550

Merged
don-petry merged 2 commits into
mainfrom
fix/feature-ideation-template-bridge
Jun 27, 2026
Merged

don-petry merged 2 commits into
mainfrom
fix/feature-ideation-template-bridge

Conversation

@don-petry

Copy link
Copy Markdown
Contributor

Propagates the #963/#971 bridge fix to the org caller-stub template so every adopting repo inherits it — discussion: created redispatches to workflow_dispatch (claude-code-action aborts on discussion contexts), mirroring initiative-planner #618. Without it, new human Ideas crash with 'Unsupported event type: discussion'. Refs .github-private#963, #875.

…he template

Mirrors combsmith/.github-private#971 (#963) onto the org caller-stub
template so every adopting repo inherits the fix: claude-code-action aborts on
`discussion` event contexts, so `discussion: created` now goes through a
`redispatch` job (guarded ideas/non-bot, PAT-required) that re-invokes the
workflow via workflow_dispatch with `target_discussion`. The `ideate` reusable
call runs only on workflow_dispatch/schedule. Pattern mirrors initiative-planner #618.

Without this, new human Ideas crash with "Unsupported event type: discussion" and
are never enhanced on creation. The .github-private stub already has the fix (#971);
this propagates it to the fleet.

Refs .github-private#963, #875, #872.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner June 27, 2026 16:02
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 27, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@don-petry, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 27 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 260aaa4e-aa73-48aa-96d0-d89bae041433

📥 Commits

Reviewing files that changed from the base of the PR and between b7e6b67 and b37b7b6.

📒 Files selected for processing (1)
  • standards/workflows/feature-ideation.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/feature-ideation-template-bridge

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a redispatch bridge in the feature-ideation.yml workflow to bypass limitations with discussion event contexts. A new redispatch job intercepts discussion: created events and triggers a workflow_dispatch run with the discussion number passed as target_discussion. The main ideate job is updated to run only on non-discussion events, utilizing the new input. There are no review comments, so no further feedback is provided.

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (applied)

Changes committed and pushed.

@don-petry
don-petry enabled auto-merge (squash) June 27, 2026 16:05
@don-petry
don-petry disabled auto-merge June 27, 2026 16:05
@sonarqubecloud

Copy link
Copy Markdown

@don-petry

Copy link
Copy Markdown
Contributor Author

Dev-Lead — review-changes (no-changes)

No changes were needed for this PR.

@don-petry
don-petry enabled auto-merge (squash) June 27, 2026 16:08
@don-petry

Copy link
Copy Markdown
Contributor Author

@donpetry-bot review

@donpetry-bot

Copy link
Copy Markdown
Contributor

@don-petry I'm on it — starting a fresh review now. Results will appear in a few minutes.

@donpetry-bot donpetry-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — APPROVED ✓

Risk: LOW
Reviewed commit: b37b7b6eb3d7822553c0b2dfa15c9574c9325074
Review mode: triage-approved (single reviewer)

Summary

Single-file change to the org caller-stub template standards/workflows/feature-ideation.yml (+48/-13). Adds a discussion → workflow_dispatch redispatch bridge so new human Ideas (Discussions) are enhanced without hitting claude-code-action's 'Unsupported event type: discussion' abort. Mirrors the established initiative-planner #618 pattern. Triage already cleared this as low-risk; this is a confirmation review and the assessment holds.

Linked issue analysis

No closingIssuesReferences — the PR uses Refs .github-private#963, #875, #872 (non-closing). The stated goal (propagate the #963/#971 discussion-context bridge fix to the org template) is fully reflected in the diff: a new redispatch job, a new internal target_discussion input, and the ideate job gated to non-discussion events.

Findings

No blocking findings. GitHub Actions security posture is sound:

  • redispatch job runs with permissions: {} (least privilege).
  • Untrusted-context values are passed via env: (DISCUSSION_NUMBER, REPO) and referenced as shell vars — no ${{ }} interpolation inside run:, so no script-injection surface (the discussion number is an integer regardless).
  • PAT guard fails fast if GH_PAT_WORKFLOWS is absent (a workflow_dispatch fired with GITHUB_TOKEN silently never starts — correct rationale).
  • No re-dispatch loop: redispatch only fires on discussion, ideate only on non-discussion; the dispatched run takes the ideate path.
  • No hardcoded secrets (only secrets.GH_PAT_WORKFLOWS reference). Secret-scanning MCP tool unavailable this session; CI gitleaks check passed.
    Comments are accurate and the 'Do not edit this line' guidance is preserved.

CI status

All required checks green or appropriately skipped. SUCCESS: CodeQL (Analyze actions), SonarCloud (Quality Gate passed, 0 new issues), Secret scan (gitleaks), ShellCheck, Lint, Agent Security Scan, AgentShield, Feature Ideation Tests (lint/schema/bats), Dependency audit, CodeRabbit. SKIPPED: dependabot-automerge, ci-relay, and non-applicable language audits. gemini-code-assist reviewed with no actionable comments; coderabbit/codex were rate/usage limited (non-blocking). mergeStateStatus BLOCKED only because human review (org-leads) is still required.


Reviewed automatically by the PR-review agent (single-reviewer mode: fable 5). Reply if you need a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants